Skip to content

Conversation

@Neraste
Copy link
Member

@Neraste Neraste commented Jan 27, 2025

Remove path in the spirit of DakaraProject/dakara-base#51.

@Neraste Neraste added the refactor Make things more beautiful inside, but same outside label Jan 27, 2025
@Neraste Neraste self-assigned this Jan 27, 2025
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (996e398) to head (78ad00e).

Files with missing lines Patch % Lines
src/dakara_player/media_player/mpv.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
- Coverage    98.09%   98.03%   -0.07%     
===========================================
  Files           16       16              
  Lines         1366     1374       +8     
===========================================
+ Hits          1340     1347       +7     
- Misses          26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neraste Neraste marked this pull request as ready for review February 8, 2025 22:45
@Neraste Neraste merged commit 7f312c8 into develop Feb 16, 2025
@Neraste Neraste deleted the refactor/remove_path branch February 16, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Make things more beautiful inside, but same outside

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants